Jeremy Reizenstein bf3bc6f8e3 screen cameras lose -1
Summary:
All the renderers in PyTorch3D (pointclouds including pulsar, meshes, raysampling) use align_corners=False style. NDC space goes between the edges of the outer pixels. For a non square image with W>H, the vertical NDC space goes from -1 to 1 and the horizontal from -W/H to W/H.

However it was recently pointed out that functionality which deals with screen space inside the camera classes is inconsistent with this. It unintentionally uses align_corners=True. This fixes that.

This would change behaviour of the following:
- If you create a camera in screen coordinates, i.e. setting in_ndc=False, then anything you do with the camera which touches NDC space may be affected, including trying to use renderers. The transform_points_screen function will not be affected...
- If you call the function “transform_points_screen” on a camera defined in NDC space results will be different. I have illustrated in the diff how to get the old results from the new results but this probably isn’t the right long-term solution..

Reviewed By: gkioxari

Differential Revision: D32536305

fbshipit-source-id: 377325a9137282971dcb7ca11a6cba3fc700c9ce
2021-12-07 15:04:20 -08:00
..
2021-10-07 18:42:09 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-08-12 14:06:32 -07:00
2021-06-22 03:45:27 -07:00
2021-09-02 09:32:29 -07:00
2021-06-22 03:45:27 -07:00
2021-12-07 15:04:20 -08:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-24 15:56:01 -07:00
2021-06-22 03:45:27 -07:00
2021-09-30 00:48:52 -07:00
2021-06-22 03:45:27 -07:00
2021-07-01 16:08:40 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-28 04:28:06 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-12-07 15:04:20 -08:00
2021-10-26 14:35:30 -07:00
2021-06-22 03:45:27 -07:00
2021-10-11 06:13:01 -07:00
2021-06-28 06:31:35 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2021-06-22 03:45:27 -07:00
2020-01-23 11:53:46 -08:00