Roman Shapovalov
1b39cebe92
Sign issue about quaternion_to_matrix and matrix_to_quaternion
...
Summary:
As reported on github, `matrix_to_quaternion` was incorrect for rotations by 180˚. We resolved the sign of the component `i` based on the sign of `i*r`, assuming `r > 0`, which is untrue if `r == 0`.
This diff handles special cases and ensures we use the non-zero elements to copy the sign from.
Reviewed By: bottler
Differential Revision: D29149465
fbshipit-source-id: cd508cc31567fc37ea3463dd7e8c8e8d5d64a235
2021-06-18 06:40:02 -07:00
..
2021-06-11 14:33:40 -07:00
2020-11-10 21:27:01 -08:00
2020-01-23 11:53:46 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-12-18 07:25:50 -08:00
2020-11-03 13:06:35 -08:00
2021-02-12 07:05:55 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2021-01-05 03:39:24 -08:00
2020-11-03 13:06:35 -08:00
2021-02-08 14:32:39 -08:00
2020-12-15 14:15:32 -08:00
2021-01-05 03:59:20 -08:00
2021-01-20 13:08:35 -08:00
2021-01-06 06:23:48 -08:00
2021-01-06 06:23:48 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2020-11-03 13:06:35 -08:00
2021-06-03 18:30:54 -07:00
2021-06-09 15:06:53 -07:00
2021-04-08 20:03:04 -07:00
2021-05-26 04:54:19 -07:00
2021-02-03 18:24:27 -08:00
2021-02-08 14:32:39 -08:00
2020-05-04 09:56:44 -07:00
2021-06-03 18:30:54 -07:00
2020-04-24 09:11:04 -07:00
2020-05-05 11:09:45 -07:00
2020-04-24 09:11:04 -07:00
2020-08-07 01:59:58 -07:00
2020-07-29 16:11:23 -07:00
2021-05-26 04:54:19 -07:00
2021-04-20 03:11:34 -07:00
2021-05-07 05:01:58 -07:00
2021-05-04 05:36:51 -07:00
2020-07-02 16:09:05 -07:00
2020-07-29 05:01:07 -07:00
2021-04-08 20:03:04 -07:00
2020-03-29 14:51:02 -07:00
2021-05-07 05:04:08 -07:00
2020-11-30 11:38:04 -08:00
2021-02-10 21:23:17 -08:00
2021-06-08 02:52:06 -07:00
2020-03-29 14:51:02 -07:00
2021-06-09 15:50:09 -07:00
2020-04-06 06:41:00 -07:00
2020-04-24 09:11:04 -07:00
2020-07-16 10:19:43 -07:00
2020-06-15 10:11:26 -07:00
2021-06-09 15:50:09 -07:00
2021-04-09 09:58:54 -07:00
2020-11-10 21:27:01 -08:00
2021-04-09 09:58:54 -07:00
2021-04-12 19:10:18 -07:00
2021-04-08 09:38:43 -07:00
2021-04-09 09:58:54 -07:00
2021-04-12 19:10:18 -07:00
2021-04-08 20:03:04 -07:00
2021-04-09 09:58:54 -07:00
2021-01-06 04:01:29 -08:00
2021-02-08 14:32:39 -08:00
2021-06-15 07:51:12 -07:00
2021-06-14 11:48:27 -07:00
2020-12-14 15:28:04 -08:00
2021-04-12 19:10:18 -07:00
2021-04-09 09:58:54 -07:00
2020-03-29 14:51:02 -07:00
2021-06-18 06:40:02 -07:00
2021-05-07 05:04:08 -07:00
2021-06-17 01:35:37 -07:00
2021-04-12 19:10:18 -07:00
2021-04-09 09:58:54 -07:00
2021-01-04 09:42:52 -08:00
2021-06-14 04:02:59 -07:00
2021-06-11 13:38:46 -07:00
2021-06-09 15:50:09 -07:00
2020-04-17 10:39:43 -07:00
2021-06-09 15:50:09 -07:00
2020-01-23 11:53:46 -08:00