423A35C7/sam2
1
0
Fork 0
mirror of https://github.com/facebookresearch/sam2.git synced 2025-09-18 04:32:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

[sam2][demo][1/x] Remove adding object constraint after popagation

Browse Source 
Summary:

PR #486 changed propagation to track each object independently. This allows to add objects after the initial propagation.

The frontend has a constraint that would prevent users from adding new objects after the initial "tracking". Now that the model supports tracking objects independently, we can remove this constraint from the UI.

Test Plan:

`cd demo/frontend`

`yarn lint`
```
(base) ➜ demo/frontend $ yarn lint                                                                                                                ⎇ remotes/origin/HEAD*
yarn run v1.18.0
$ eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0
✨  Done in 16.98s.
```
This commit is contained in:
Roman Rädle 2024-12-24 16:33:40 -08:00
parent 2b90b9f5ce
commit d2f83d0d54
3 changed files with 19 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
demo/frontend/src/common/components/annotations/AddObjectButton.tsx
View File

@ -15,18 +15,33 @@
*/
import useMessagesSnackbar from '@/common/components/snackbar/useDemoMessagesSnackbar';
import useVideo from '@/common/components/video/editor/useVideo';
import {activeTrackletObjectIdAtom, labelTypeAtom} from '@/demo/atoms';
import {
activeTrackletObjectIdAtom,
isStreamingAtom,
labelTypeAtom,
} from '@/demo/atoms';
import {Add} from '@carbon/icons-react';
import {useSetAtom} from 'jotai';
import {useAtomValue, useSetAtom} from 'jotai';
export default function AddObjectButton() {
const video = useVideo();
const setActiveTrackletId = useSetAtom(activeTrackletObjectIdAtom);
const isStreaming = useAtomValue(isStreamingAtom);
const setLabelType = useSetAtom(labelTypeAtom);
const {enqueueMessage} = useMessagesSnackbar();
async function addObject() {
enqueueMessage('addObjectClick');
// Make sure video is paused to allow users adding clicks. Either abort
// streaming if propagation is running or simply pause the video.
if (isStreaming) {
void video?.abortStreamMasks();
} else {
video?.pause();
}
// Create tracklet for video.
const tracklet = await video?.createTracklet();
if (tracklet != null) {
setActiveTrackletId(tracklet.id);

3
demo/frontend/src/demo/DemoConfig.tsx
View File

@ -24,8 +24,7 @@ export const DEMO_SHORT_NAME = 'SAM 2 Demo';
export const RESEARCH_BY_META_AI = 'By Meta FAIR';
export const DEMO_FRIENDLY_NAME = 'Segment Anything 2 Demo';
export const VIDEO_WATERMARK_TEXT = `Modified with ${DEMO_FRIENDLY_NAME}`;
export const PROJECT_GITHUB_URL =
'https://github.com/facebookresearch/sam2';
export const PROJECT_GITHUB_URL = 'https://github.com/facebookresearch/sam2';
export const AIDEMOS_URL = 'https://aidemos.meta.com';
export const ABOUT_URL = 'https://ai.meta.com/sam2';
export const EMAIL_ADDRESS = 'segment-anything@meta.com';

7
demo/frontend/src/demo/atoms.ts
View File

@ -123,14 +123,9 @@ export const pointsAtom = atom<SegmentationPoint[]>(get => {
export const labelTypeAtom = atom<'positive' | 'negative'>('positive');
export const isAddObjectEnabledAtom = atom<boolean>(get => {
const session = get(sessionAtom);
const trackletsInitialized = get(areTrackletObjectsInitializedAtom);
const isObjectLimitReached = get(isTrackletObjectLimitReachedAtom);
return (
session?.ranPropagation === false &&
trackletsInitialized &&
!isObjectLimitReached
);
return trackletsInitialized && !isObjectLimitReached;
});
export const codeEditorOpenedAtom = atom<boolean>(false);