Shader API more consistent naming

Browse Source

Summary:
Renamed shaders to be prefixed with Hard/Soft depending on if they use a probabalistic blending (Soft) or use the closest face (Hard).

There is some code duplication but I thought it would be cleaner to have separate shaders for each task rather than:
- inheritance (which we discussed previously that we want to avoid)
- boolean (hard/soft) or a string (hard/soft) - new blending functions other than the ones provided would need if statements in the current shaders which might get messy.

Also added a `flat_shading` function and a `FlatShader` - I could make this into a tutorial as it was really easy to add a new shader and it might be a nice showcase.

NOTE: There are a few more places where the naming will need to change (e.g the tutorials) but I wanted to reach a consensus on this before changing it everywhere.

Reviewed By: jcjohnson

Differential Revision: D19761036

fbshipit-source-id: f972f6530c7f66dc5550b0284c191abc4a7f6fc4

...

This commit is contained in:

Nikhila Ravi

2020-02-19 23:15:12 -08:00

committed by Facebook Github Bot

parent 60f3c4e7d2

commit f0dc65110a

9 changed files with 293 additions and 82 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

55

docs/tutorials/camera_position_optimization_with_differentiable_rendering.ipynb

File diff suppressed because one or more lines are too long

36

docs/tutorials/render_textured_meshes.ipynb

File diff suppressed because one or more lines are too long