mirror of
https://github.com/facebookresearch/pytorch3d.git
synced 2025-12-20 06:10:34 +08:00
Shader API more consistent naming
Summary: Renamed shaders to be prefixed with Hard/Soft depending on if they use a probabalistic blending (Soft) or use the closest face (Hard). There is some code duplication but I thought it would be cleaner to have separate shaders for each task rather than: - inheritance (which we discussed previously that we want to avoid) - boolean (hard/soft) or a string (hard/soft) - new blending functions other than the ones provided would need if statements in the current shaders which might get messy. Also added a `flat_shading` function and a `FlatShader` - I could make this into a tutorial as it was really easy to add a new shader and it might be a nice showcase. NOTE: There are a few more places where the naming will need to change (e.g the tutorials) but I wanted to reach a consensus on this before changing it everywhere. Reviewed By: jcjohnson Differential Revision: D19761036 fbshipit-source-id: f972f6530c7f66dc5550b0284c191abc4a7f6fc4
This commit is contained in:
committed by
Facebook Github Bot
parent
60f3c4e7d2
commit
f0dc65110a
4
.gitignore
vendored
4
.gitignore
vendored
@@ -2,6 +2,10 @@ build/
|
||||
dist/
|
||||
*.egg-info/
|
||||
**/__pycache__/
|
||||
*-checkpoint.ipynb
|
||||
**/.ipynb_checkpoints
|
||||
**/.ipynb_checkpoints/**
|
||||
|
||||
|
||||
# Docusaurus site
|
||||
website/yarn.lock
|
||||
|
||||
Reference in New Issue
Block a user