423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-02 03:42:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

MACOSX_DEPLOYMENT_TARGET=10.14

Browse Source 
Summary:
pybind now seems to need C++17 on a mac, so advise people to use it. (Also delete an unused variable to silence a warning I got on a mac build.)

Reported in github issue #68.

Reviewed By: nikhilaravi

Differential Revision: D19970512

fbshipit-source-id: f9be20c8ed425bd6ba8d009a7d62dad658dccdb1
This commit is contained in:
Jeremy Reizenstein 2020-02-19 08:42:05 -08:00 committed by Facebook Github Bot
parent 234658901a
commit bdc2bb578c
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
INSTALL.md
View File

@ -70,5 +70,5 @@ To rebuild after installing from a local clone run, `rm -rf build/ **/*.so` then
**Install from local clone on macOS:** **Install from local clone on macOS:**
``` ```
MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++ pip install -e . MACOSX_DEPLOYMENT_TARGET=10.14 CC=clang CXX=clang++ pip install -e .
``` ```

2
packaging/pkg_helpers.bash
View File

@ -113,7 +113,7 @@ setup_build_version() {
# Set some useful variables for OS X, if applicable # Set some useful variables for OS X, if applicable
setup_macos() { setup_macos() {
if [[ "$(uname)" == Darwin ]]; then if [[ "$(uname)" == Darwin ]]; then
export MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++ export MACOSX_DEPLOYMENT_TARGET=10.14 CC=clang CXX=clang++
fi fi
} }

1
pytorch3d/csrc/face_areas_normals/face_areas_normals_cpu.cpp
View File

@ -6,7 +6,6 @@
std::tuple<at::Tensor, at::Tensor> FaceAreasNormalsCpu( std::tuple<at::Tensor, at::Tensor> FaceAreasNormalsCpu(
at::Tensor verts, at::Tensor verts,
at::Tensor faces) { at::Tensor faces) {
const int V = verts.size(0);
const int F = faces.size(0); const int F = faces.size(0);
at::Tensor areas = at::empty({F}, verts.options()); at::Tensor areas = at::empty({F}, verts.options());