From bdc2bb578cbfb8c6a355da7c27b6949ff8063842 Mon Sep 17 00:00:00 2001 From: Jeremy Reizenstein Date: Wed, 19 Feb 2020 08:42:05 -0800 Subject: [PATCH] MACOSX_DEPLOYMENT_TARGET=10.14 Summary: pybind now seems to need C++17 on a mac, so advise people to use it. (Also delete an unused variable to silence a warning I got on a mac build.) Reported in github issue #68. Reviewed By: nikhilaravi Differential Revision: D19970512 fbshipit-source-id: f9be20c8ed425bd6ba8d009a7d62dad658dccdb1 --- INSTALL.md | 2 +- packaging/pkg_helpers.bash | 2 +- pytorch3d/csrc/face_areas_normals/face_areas_normals_cpu.cpp | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/INSTALL.md b/INSTALL.md index cd17c6fb..d9b9f020 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -70,5 +70,5 @@ To rebuild after installing from a local clone run, `rm -rf build/ **/*.so` then **Install from local clone on macOS:** ``` -MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++ pip install -e . +MACOSX_DEPLOYMENT_TARGET=10.14 CC=clang CXX=clang++ pip install -e . ``` diff --git a/packaging/pkg_helpers.bash b/packaging/pkg_helpers.bash index 7cb289c2..dd230970 100644 --- a/packaging/pkg_helpers.bash +++ b/packaging/pkg_helpers.bash @@ -113,7 +113,7 @@ setup_build_version() { # Set some useful variables for OS X, if applicable setup_macos() { if [[ "$(uname)" == Darwin ]]; then - export MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++ + export MACOSX_DEPLOYMENT_TARGET=10.14 CC=clang CXX=clang++ fi } diff --git a/pytorch3d/csrc/face_areas_normals/face_areas_normals_cpu.cpp b/pytorch3d/csrc/face_areas_normals/face_areas_normals_cpu.cpp index 34b050c4..f760ec30 100644 --- a/pytorch3d/csrc/face_areas_normals/face_areas_normals_cpu.cpp +++ b/pytorch3d/csrc/face_areas_normals/face_areas_normals_cpu.cpp @@ -6,7 +6,6 @@ std::tuple FaceAreasNormalsCpu( at::Tensor verts, at::Tensor faces) { - const int V = verts.size(0); const int F = faces.size(0); at::Tensor areas = at::empty({F}, verts.options());