MACOSX_DEPLOYMENT_TARGET=10.14

Summary:
pybind now seems to need C++17 on a mac, so advise people to use it. (Also delete an unused variable to silence a warning I got on a mac build.)

Reported in github issue #68.

Reviewed By: nikhilaravi

Differential Revision: D19970512

fbshipit-source-id: f9be20c8ed425bd6ba8d009a7d62dad658dccdb1
This commit is contained in:
Jeremy Reizenstein
2020-02-19 08:42:05 -08:00
committed by Facebook Github Bot
parent 234658901a
commit bdc2bb578c
3 changed files with 2 additions and 3 deletions

View File

@@ -113,7 +113,7 @@ setup_build_version() {
# Set some useful variables for OS X, if applicable
setup_macos() {
if [[ "$(uname)" == Darwin ]]; then
export MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++
export MACOSX_DEPLOYMENT_TARGET=10.14 CC=clang CXX=clang++
fi
}