423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-03 04:12:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Pass epsilon value properly to the transformation (#418)

Browse Source 
Summary:
As for now, epsilon value is ignored, since `kwargs` are passed to constructor only

Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/418

Reviewed By: gkioxari

Differential Revision: D24730500

Pulled By: nikhilaravi

fbshipit-source-id: 7cce820dbe14f8c74d3df4f18c45d50e228c6a45
This commit is contained in:
Evgeniy Zheltonozhskiy 2020-12-14 15:21:23 -08:00 committed by Facebook GitHub Bot
parent f248bfc415
commit 831e64efb0
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pytorch3d/renderer/mesh/rasterizer.py
View File

@ -109,11 +109,12 @@ class MeshRasterizer(nn.Module):
# NOTE: Retaining view space z coordinate for now. # NOTE: Retaining view space z coordinate for now.
# TODO: Revisit whether or not to transform z coordinate to [-1, 1] or # TODO: Revisit whether or not to transform z coordinate to [-1, 1] or
# [0, 1] range. # [0, 1] range.
eps = kwargs.get("eps", None)
verts_view = cameras.get_world_to_view_transform(**kwargs).transform_points( verts_view = cameras.get_world_to_view_transform(**kwargs).transform_points(
verts_world verts_world, eps=eps
) )
verts_screen = cameras.get_projection_transform(**kwargs).transform_points( verts_screen = cameras.get_projection_transform(**kwargs).transform_points(
verts_view verts_view, eps=eps
) )
verts_screen[..., 2] = verts_view[..., 2] verts_screen[..., 2] = verts_view[..., 2]
meshes_screen = meshes_world.update_padded(new_verts_padded=verts_screen) meshes_screen = meshes_world.update_padded(new_verts_padded=verts_screen)