From 831e64efb0e647918a90be4bcca653a0611664a1 Mon Sep 17 00:00:00 2001 From: Evgeniy Zheltonozhskiy Date: Mon, 14 Dec 2020 15:21:23 -0800 Subject: [PATCH] Pass epsilon value properly to the transformation (#418) Summary: As for now, epsilon value is ignored, since `kwargs` are passed to constructor only Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/418 Reviewed By: gkioxari Differential Revision: D24730500 Pulled By: nikhilaravi fbshipit-source-id: 7cce820dbe14f8c74d3df4f18c45d50e228c6a45 --- pytorch3d/renderer/mesh/rasterizer.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pytorch3d/renderer/mesh/rasterizer.py b/pytorch3d/renderer/mesh/rasterizer.py index 899ee0fa..f4284e8f 100644 --- a/pytorch3d/renderer/mesh/rasterizer.py +++ b/pytorch3d/renderer/mesh/rasterizer.py @@ -109,11 +109,12 @@ class MeshRasterizer(nn.Module): # NOTE: Retaining view space z coordinate for now. # TODO: Revisit whether or not to transform z coordinate to [-1, 1] or # [0, 1] range. + eps = kwargs.get("eps", None) verts_view = cameras.get_world_to_view_transform(**kwargs).transform_points( - verts_world + verts_world, eps=eps ) verts_screen = cameras.get_projection_transform(**kwargs).transform_points( - verts_view + verts_view, eps=eps ) verts_screen[..., 2] = verts_view[..., 2] meshes_screen = meshes_world.update_padded(new_verts_padded=verts_screen)