camera refactoring

Browse Source

Summary:
Refactor cameras
* CamerasBase was enhanced with `transform_points_screen` that transforms projected points from NDC to screen space
* OpenGLPerspective, OpenGLOrthographic -> FoVPerspective, FoVOrthographic
* SfMPerspective, SfMOrthographic -> Perspective, Orthographic
* PerspectiveCamera can optionally be constructred with screen space parameters
* Note on Cameras and coordinate systems was added

Reviewed By: nikhilaravi

Differential Revision: D23168525

fbshipit-source-id: dd138e2b2cc7e0e0d9f34c45b8251c01266a2063

...

This commit is contained in:

Georgia Gkioxari

2020-08-20 22:20:41 -07:00

committed by Facebook GitHub Bot

parent 9242e7e65d

commit 57a22e7306

65 changed files with 896 additions and 279 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

BIN

tests/data/test_FoVOrthographicCameras_silhouette.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 48 KiB

BIN

tests/data/test_FoVPerspectiveCameras_silhouette.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 8.7 KiB

BIN

tests/data/test_OrthographicCameras_silhouette.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 48 KiB

BIN

tests/data/test_PerspectiveCameras_silhouette.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 5.5 KiB

BIN

tests/data/test_silhouette.png

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 8.8 KiB

BIN

tests/data/test_simple_sphere_batched_flat_FoVPerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 26 KiB

BIN

tests/data/test_simple_sphere_batched_gouraud_FoVPerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 18 KiB

BIN

tests/data/test_simple_sphere_batched_phong_FoVPerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 18 KiB

BIN

tests/data/test_simple_sphere_dark.png

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 3.4 KiB

BIN

tests/data/test_simple_sphere_dark_FoVOrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 3.7 KiB

BIN

tests/data/test_simple_sphere_dark_FoVPerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 2.8 KiB

BIN

tests/data/test_simple_sphere_dark_OrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 3.7 KiB

BIN

tests/data/test_simple_sphere_dark_PerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 2.0 KiB

BIN

tests/data/test_simple_sphere_dark_elevated_FoVOrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 7.8 KiB

BIN

tests/data/test_simple_sphere_dark_elevated_FoVPerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 3.8 KiB

BIN

tests/data/test_simple_sphere_dark_elevated_OrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 7.8 KiB

BIN

tests/data/test_simple_sphere_dark_elevated_PerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 2.5 KiB

BIN

tests/data/test_simple_sphere_dark_elevated_camera.png

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 3.8 KiB

BIN

tests/data/test_simple_sphere_light_flat.png

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 26 KiB

BIN

tests/data/test_simple_sphere_light_flat_FoVOrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 34 KiB

BIN

tests/data/test_simple_sphere_light_flat_FoVPerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 26 KiB

BIN

tests/data/test_simple_sphere_light_flat_OrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 34 KiB

BIN

tests/data/test_simple_sphere_light_flat_PerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 13 KiB

BIN

tests/data/test_simple_sphere_light_flat_elevated_FoVOrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 25 KiB

BIN

tests/data/test_simple_sphere_light_flat_elevated_FoVPerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 15 KiB

BIN

tests/data/test_simple_sphere_light_flat_elevated_OrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 25 KiB

BIN

tests/data/test_simple_sphere_light_flat_elevated_PerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 8.5 KiB

BIN

tests/data/test_simple_sphere_light_flat_elevated_camera.png

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 15 KiB

BIN

tests/data/test_simple_sphere_light_gouraud.png

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 18 KiB

BIN

tests/data/test_simple_sphere_light_gouraud_FoVOrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 23 KiB

BIN

tests/data/test_simple_sphere_light_gouraud_FoVPerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 18 KiB

BIN

tests/data/test_simple_sphere_light_gouraud_OrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 23 KiB

BIN

tests/data/test_simple_sphere_light_gouraud_PerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 9.1 KiB

BIN

tests/data/test_simple_sphere_light_gouraud_elevated_FoVOrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 17 KiB

BIN

tests/data/test_simple_sphere_light_gouraud_elevated_FoVPerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 10 KiB

BIN

tests/data/test_simple_sphere_light_gouraud_elevated_OrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 17 KiB

BIN

tests/data/test_simple_sphere_light_gouraud_elevated_PerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 5.8 KiB

BIN

tests/data/test_simple_sphere_light_gouraud_elevated_camera.png

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 10 KiB

BIN

tests/data/test_simple_sphere_light_phong.png

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 21 KiB

BIN

tests/data/test_simple_sphere_light_phong_FoVOrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 22 KiB

BIN

tests/data/test_simple_sphere_light_phong_FoVPerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 18 KiB

BIN

tests/data/test_simple_sphere_light_phong_OrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 22 KiB

BIN

tests/data/test_simple_sphere_light_phong_PerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 8.8 KiB

BIN

tests/data/test_simple_sphere_light_phong_elevated_FoVOrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 16 KiB

BIN

tests/data/test_simple_sphere_light_phong_elevated_FoVPerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 10 KiB

BIN

tests/data/test_simple_sphere_light_phong_elevated_OrthographicCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 16 KiB

BIN

tests/data/test_simple_sphere_light_phong_elevated_PerspectiveCameras.png Normal file

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 5.6 KiB

BIN

tests/data/test_simple_sphere_light_phong_elevated_camera.png

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 10 KiB