423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-22 05:42:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Minor fix in HarmonicEmbedding docstring (#13)

Browse Source 
Summary:
The multiplicative factors in function embeddings go from `2**0` to `2**(self.n_harmonic_functions-1)`, and not from `2**0` to `2**self.n_harmonic_functions`.

Pull Request resolved: https://github.com/fairinternal/pytorch3d/pull/13

Reviewed By: nikhilaravi

Differential Revision: D28637894

Pulled By: ignacio-rocco

fbshipit-source-id: da20f39eba9aaa09af5b24be1554a3bfd7556281
This commit is contained in:
Ignacio Rocco 2021-05-27 03:13:25 -07:00 committed by Facebook GitHub Bot
parent ed6983ea84
commit 4efadaecfc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/tutorials/fit_simple_neural_radiance_field.ipynb
View File

@ -257,12 +257,12 @@
" sin(2*x[..., i]),\n",
" sin(4*x[..., i]),\n",
" ...\n",
" sin(2**self.n_harmonic_functions * x[..., i]),\n",
" sin(2**(self.n_harmonic_functions-1) * x[..., i]),\n",
" cos(x[..., i]),\n",
" cos(2*x[..., i]),\n",
" cos(4*x[..., i]),\n",
" ...\n",
" cos(2**self.n_harmonic_functions * x[..., i])\n",
" cos(2**(self.n_harmonic_functions-1) * x[..., i])\n",
" ]\n",
" \n",
" Note that `x` is also premultiplied by `omega0` before\n",