423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-02 11:52:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

remove bin_size from the settings in the tutorials

Browse Source 
Summary: Remove `bin_size` and `max_faces_per_pixel` from being specified. This means the coarse-to-fine rasterization will be used by default and will help avoid confusion with the naive version.

Reviewed By: jcjohnson

Differential Revision: D20908905

fbshipit-source-id: c181c88e844d888aa81a36870918307961dc1175
This commit is contained in:
Nikhila Ravi 2020-04-08 10:05:04 -07:00 committed by Facebook GitHub Bot
parent 0fecb2ddb9
commit 474c8b456a
3 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/tutorials/camera_position_optimization_with_differentiable_rendering.ipynb
View File

@ -235,8 +235,6 @@
" image_size=256, \n", " image_size=256, \n",
" blur_radius=np.log(1. / 1e-4 - 1.) * blend_params.sigma, \n", " blur_radius=np.log(1. / 1e-4 - 1.) * blend_params.sigma, \n",
" faces_per_pixel=100, \n", " faces_per_pixel=100, \n",
" bin_size = None, # this setting controls whether naive or coarse-to-fine rasterization is used\n",
" max_faces_per_bin = None # this setting is for coarse rasterization\n",
")\n", ")\n",
"\n", "\n",
"# Create a silhouette mesh renderer by composing a rasterizer and a shader. \n", "# Create a silhouette mesh renderer by composing a rasterizer and a shader. \n",
@ -254,7 +252,6 @@
" image_size=256, \n", " image_size=256, \n",
" blur_radius=0.0, \n", " blur_radius=0.0, \n",
" faces_per_pixel=1, \n", " faces_per_pixel=1, \n",
" bin_size=0\n",
")\n", ")\n",
"# We can add a point light in front of the object. \n", "# We can add a point light in front of the object. \n",
"lights = PointLights(device=device, location=((2.0, 2.0, -2.0),))\n", "lights = PointLights(device=device, location=((2.0, 2.0, -2.0),))\n",
@ -304,7 +301,7 @@
] ]
}, },
"metadata": { "metadata": {
"bento_obj_id": "140092634331216", "bento_obj_id": "139625337525584",
"needs_background": "light" "needs_background": "light"
}, },
"output_type": "display_data" "output_type": "display_data"

8
docs/tutorials/render_colored_points.ipynb
View File

@ -166,9 +166,7 @@
"raster_settings = PointsRasterizationSettings(\n", "raster_settings = PointsRasterizationSettings(\n",
" image_size=512, \n", " image_size=512, \n",
" radius = 0.003,\n", " radius = 0.003,\n",
" points_per_pixel = 10,\n", " points_per_pixel = 10\n",
" bin_size = None,\n",
" max_points_per_bin = None\n",
")\n", ")\n",
"\n", "\n",
"\n", "\n",
@ -247,9 +245,7 @@
"raster_settings = PointsRasterizationSettings(\n", "raster_settings = PointsRasterizationSettings(\n",
" image_size=512, \n", " image_size=512, \n",
" radius = 0.003,\n", " radius = 0.003,\n",
" points_per_pixel = 10,\n", " points_per_pixel = 10\n",
" bin_size = None,\n",
" max_points_per_bin = None\n",
")\n", ")\n",
"\n", "\n",
"\n", "\n",

2
docs/tutorials/render_textured_meshes.ipynb
View File

@ -322,8 +322,6 @@
" image_size=512, \n", " image_size=512, \n",
" blur_radius=0.0, \n", " blur_radius=0.0, \n",
" faces_per_pixel=1, \n", " faces_per_pixel=1, \n",
" bin_size = None, # this setting controls whether naive or coarse-to-fine rasterization is used\n",
" max_faces_per_bin = None # this setting is for coarse rasterization\n",
")\n", ")\n",
"\n", "\n",
"# Place a point light in front of the object. As mentioned above, the front of the cow is facing the \n", "# Place a point light in front of the object. As mentioned above, the front of the cow is facing the \n",