From 474c8b456a8dbd5ceada57980ec7c967e46fb027 Mon Sep 17 00:00:00 2001 From: Nikhila Ravi Date: Wed, 8 Apr 2020 10:05:04 -0700 Subject: [PATCH] remove bin_size from the settings in the tutorials Summary: Remove `bin_size` and `max_faces_per_pixel` from being specified. This means the coarse-to-fine rasterization will be used by default and will help avoid confusion with the naive version. Reviewed By: jcjohnson Differential Revision: D20908905 fbshipit-source-id: c181c88e844d888aa81a36870918307961dc1175 --- ...ition_optimization_with_differentiable_rendering.ipynb | 5 +---- docs/tutorials/render_colored_points.ipynb | 8 ++------ docs/tutorials/render_textured_meshes.ipynb | 2 -- 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/docs/tutorials/camera_position_optimization_with_differentiable_rendering.ipynb b/docs/tutorials/camera_position_optimization_with_differentiable_rendering.ipynb index 56e89b55..a7b60921 100644 --- a/docs/tutorials/camera_position_optimization_with_differentiable_rendering.ipynb +++ b/docs/tutorials/camera_position_optimization_with_differentiable_rendering.ipynb @@ -235,8 +235,6 @@ " image_size=256, \n", " blur_radius=np.log(1. / 1e-4 - 1.) * blend_params.sigma, \n", " faces_per_pixel=100, \n", - " bin_size = None, # this setting controls whether naive or coarse-to-fine rasterization is used\n", - " max_faces_per_bin = None # this setting is for coarse rasterization\n", ")\n", "\n", "# Create a silhouette mesh renderer by composing a rasterizer and a shader. \n", @@ -254,7 +252,6 @@ " image_size=256, \n", " blur_radius=0.0, \n", " faces_per_pixel=1, \n", - " bin_size=0\n", ")\n", "# We can add a point light in front of the object. \n", "lights = PointLights(device=device, location=((2.0, 2.0, -2.0),))\n", @@ -304,7 +301,7 @@ ] }, "metadata": { - "bento_obj_id": "140092634331216", + "bento_obj_id": "139625337525584", "needs_background": "light" }, "output_type": "display_data" diff --git a/docs/tutorials/render_colored_points.ipynb b/docs/tutorials/render_colored_points.ipynb index d552b0e1..e70792ae 100644 --- a/docs/tutorials/render_colored_points.ipynb +++ b/docs/tutorials/render_colored_points.ipynb @@ -166,9 +166,7 @@ "raster_settings = PointsRasterizationSettings(\n", " image_size=512, \n", " radius = 0.003,\n", - " points_per_pixel = 10,\n", - " bin_size = None,\n", - " max_points_per_bin = None\n", + " points_per_pixel = 10\n", ")\n", "\n", "\n", @@ -247,9 +245,7 @@ "raster_settings = PointsRasterizationSettings(\n", " image_size=512, \n", " radius = 0.003,\n", - " points_per_pixel = 10,\n", - " bin_size = None,\n", - " max_points_per_bin = None\n", + " points_per_pixel = 10\n", ")\n", "\n", "\n", diff --git a/docs/tutorials/render_textured_meshes.ipynb b/docs/tutorials/render_textured_meshes.ipynb index 7edb7f3e..d156bedd 100644 --- a/docs/tutorials/render_textured_meshes.ipynb +++ b/docs/tutorials/render_textured_meshes.ipynb @@ -322,8 +322,6 @@ " image_size=512, \n", " blur_radius=0.0, \n", " faces_per_pixel=1, \n", - " bin_size = None, # this setting controls whether naive or coarse-to-fine rasterization is used\n", - " max_faces_per_bin = None # this setting is for coarse rasterization\n", ")\n", "\n", "# Place a point light in front of the object. As mentioned above, the front of the cow is facing the \n",