423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-02 03:42:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

stratified_sampling argument: set default to None (#1324)

Browse Source 
Summary:
The self._stratified_sampling attribute is always overridden unless stratified_sampling is explicitly set to None. However, the desired default behavior is that the value of self._stratified_sampling is used unless the argument stratified_sampling is set to True/False. Changing the default to None achieves this

Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/1324

Reviewed By: bottler

Differential Revision: D39259775

Pulled By: davnov134

fbshipit-source-id: e01bb747ac80c812eb27bf22e67f5e14f29acadd
This commit is contained in:
Matthias Treder 2022-09-05 11:16:25 -07:00 committed by Facebook GitHub Bot
parent dd58ded73d
commit 438c194ec6
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pytorch3d/renderer/implicit/raysampling.py
View File

@ -124,7 +124,7 @@ class MultinomialRaysampler(torch.nn.Module):
max_depth: Optional[float] = None,
n_rays_per_image: Optional[int] = None,
n_pts_per_ray: Optional[int] = None,
stratified_sampling: bool = False,
stratified_sampling: Optional[bool] = None,
**kwargs,
) -> RayBundle:
"""
@ -313,7 +313,11 @@ class MonteCarloRaysampler(torch.nn.Module):
self._stratified_sampling = stratified_sampling
def forward(
self, cameras: CamerasBase, *, stratified_sampling: bool = False, **kwargs
self,
cameras: CamerasBase,
*,
stratified_sampling: Optional[bool] = None,
**kwargs,
) -> RayBundle:
"""
Args: