423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-01 03:12:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Replace hasattr with getattr in vision/fair/pytorch3d/pytorch3d/renderer/cameras.py

Browse Source 
Summary:
The pattern
```
X.Y if hasattr(X, "Y") else Z
```
can be replaced with
```
getattr(X, "Y", Z)
```

The [getattr](https://www.w3schools.com/python/ref_func_getattr.asp) function gives more succinct code than the [hasattr](https://www.w3schools.com/python/ref_func_hasattr.asp) function. Please use it when appropriate.

**This diff is very low risk. Green tests indicate that you can safely Accept & Ship.**

Reviewed By: bottler

Differential Revision: D44886893

fbshipit-source-id: 86ba23e837217e1ebd64bf8e27d286257894839e
This commit is contained in:
Richard Barnes 2023-04-14 04:24:54 -07:00 committed by Facebook GitHub Bot
parent 355d6332cb
commit 1af6bf4768
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pytorch3d/renderer/cameras.py
View File

@ -375,14 +375,14 @@ class CamerasBase(TensorProperties):
raise NotImplementedError()
def get_znear(self):
return self.znear if hasattr(self, "znear") else None
return getattr(self, "znear", None)
def get_image_size(self):
"""
Returns the image size, if provided, expected in the form of (height, width)
The image size is used for conversion of projected points to screen coordinates.
"""
return self.image_size if hasattr(self, "image_size") else None
return getattr(self, "image_size", None)
def __getitem__(
self, index: Union[int, List[int], torch.BoolTensor, torch.LongTensor]