mirror of
https://github.com/facebookresearch/pytorch3d.git
synced 2025-08-02 03:42:50 +08:00
e491efb81f
Summary: Lint related fixes: Improve internal/OSS consistency. Fix the fight between black and certain pyre-ignore markers by moving them to the line before. Use clang-format-8 automatically if present. Small number of pyre fixes. arc doesn't run pyre at the moment, so I put back the explicit call to pyre. I don't know if there's an option somewhere to change this. Reviewed By: nikhilaravi Differential Revision: D19780518 fbshipit-source-id: ef1c243392322fa074130f6cff2dd8a6f7738a7f
40 lines
1.1 KiB
Bash
Executable File
40 lines
1.1 KiB
Bash
Executable File
#!/bin/bash -e
|
|
# Copyright (c) Facebook, Inc. and its affiliates. All rights reserved.
|
|
|
|
# Run this script at project root by "./dev/linter.sh" before you commit
|
|
|
|
{
|
|
V=$(black --version|cut '-d ' -f3)
|
|
code='import distutils.version; assert "19.3" < distutils.version.LooseVersion("'$V'")'
|
|
python -c "${code}" 2> /dev/null
|
|
} || {
|
|
echo "Linter requires black 19.3b0 or higher!"
|
|
exit 1
|
|
}
|
|
|
|
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
|
|
DIR=$(dirname "${DIR}")
|
|
|
|
echo "Running isort..."
|
|
isort -y -sp "${DIR}"
|
|
|
|
echo "Running black..."
|
|
black -l 80 "${DIR}"
|
|
|
|
echo "Running flake..."
|
|
flake8 "${DIR}"
|
|
|
|
echo "Running clang-format ..."
|
|
clangformat=$(command -v clang-format-8 || echo clang-format)
|
|
find "${DIR}" -regex ".*\.\(cpp\|c\|cc\|cu\|cuh\|cxx\|h\|hh\|hpp\|hxx\|tcc\|mm\|m\)" -print0 | xargs -0 "${clangformat}" -i
|
|
|
|
# (cd "${DIR}"; command -v arc > /dev/null && arc lint) || true
|
|
|
|
# Run pyre internally only.
|
|
if [[ -f tests/TARGETS ]]
|
|
then
|
|
echo "Running pyre..."
|
|
echo "To restart/kill pyre server, run 'pyre restart' or 'pyre kill' in fbcode/"
|
|
( cd ~/fbsource/fbcode; pyre -l vision/fair/pytorch3d/ )
|
|
fi
|