423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-02 11:52:50 +08:00
Code Issues Packages Projects Releases Wiki Activity
704 Commits 8 Branches 20 Tags
Commit Graph

7 Commits

Author SHA1 Message Date
Jeremy Reizenstein
3b8a33e9c5 store original declared types in Configurable 
Summary: Aid reflection by adding the original declared types of replaced members of a configurable as values in _processed_members.

Reviewed By: davnov134

Differential Revision: D35358422

fbshipit-source-id: 80ef3266144c51c1c2105f349e0dd3464e230429
 2022-04-04 07:19:56 -07:00
Jeremy Reizenstein
2802fd9398 fix Optional[List] in Configurable 
Summary: Optional[not_a_type] was causing errors.

Reviewed By: davnov134

Differential Revision: D35355530

fbshipit-source-id: e9b52cfd6347ffae0fe688ef30523a4092ccf9fd
 2022-04-04 04:28:17 -07:00
Jeremy Reizenstein
24260130ce _allow_untyped for get_default_args 
Summary:
ListConfig and DictConfig members of get_default_args(X) when X is a callable will contain references to a temporary dataclass and therefore be unpicklable. Avoid this in a few cases.

Fixes https://github.com/facebookresearch/pytorch3d/issues/1144

Reviewed By: shapovalov

Differential Revision: D35258561

fbshipit-source-id: e52186825f52accee9a899e466967a4ff71b3d25
 2022-03-31 06:31:45 -07:00
Roman Shapovalov
a54ad2b912 get_default_args for callables respects non-class type annotations and Optionals 
Summary: as subj

Reviewed By: davnov134

Differential Revision: D35194863

fbshipit-source-id: c8e8f234083d4f0f93dca8d93e090ca0e1e1972d
 2022-03-29 11:36:11 -07:00
Jeremy Reizenstein
21262e38c7 Optional ReplaceableBase 
Summary: Allow things like `renderer:Optional[BaseRenderer]` in configurables.

Reviewed By: davnov134

Differential Revision: D35118339

fbshipit-source-id: 1219321b2817ed4b26fe924c6d6f73887095c985
 2022-03-29 08:43:46 -07:00
Roman Shapovalov
645a47d054 Return a typed structured config from default_args for callables 
Summary:
Before the fix, running get_default_args(C: Callable) returns an unstructured DictConfig which causes Enums to be handled incorrectly. This is a fix.

WIP update: Currently tests still fail whenever a function signature contains an untyped argument: This needs to be somehow fixed.

Reviewed By: bottler

Differential Revision: D34932124

fbshipit-source-id: ecdc45c738633cfea5caa7480ba4f790ece931e8
 2022-03-25 07:08:01 -07:00
Jeremy Reizenstein
cdd2142dd5
implicitron v0 (#1133) 
Co-authored-by: Jeremy Francis Reizenstein <bottler@users.noreply.github.com>
 2022-03-21 13:20:10 -07:00