423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-02 11:52:50 +08:00
Code Issues Packages Projects Releases Wiki Activity
696 Commits 8 Branches 20 Tags
Commit Graph

3 Commits

Author SHA1 Message Date
Jeremy Reizenstein
21262e38c7 Optional ReplaceableBase 
Summary: Allow things like `renderer:Optional[BaseRenderer]` in configurables.

Reviewed By: davnov134

Differential Revision: D35118339

fbshipit-source-id: 1219321b2817ed4b26fe924c6d6f73887095c985
 2022-03-29 08:43:46 -07:00
Roman Shapovalov
645a47d054 Return a typed structured config from default_args for callables 
Summary:
Before the fix, running get_default_args(C: Callable) returns an unstructured DictConfig which causes Enums to be handled incorrectly. This is a fix.

WIP update: Currently tests still fail whenever a function signature contains an untyped argument: This needs to be somehow fixed.

Reviewed By: bottler

Differential Revision: D34932124

fbshipit-source-id: ecdc45c738633cfea5caa7480ba4f790ece931e8
 2022-03-25 07:08:01 -07:00
Jeremy Reizenstein
cdd2142dd5
implicitron v0 (#1133) 
Co-authored-by: Jeremy Francis Reizenstein <bottler@users.noreply.github.com>
 2022-03-21 13:20:10 -07:00