From ff9c6612b457a2021d88fea119bdb9b94ba017bd Mon Sep 17 00:00:00 2001 From: Jeremy Reizenstein Date: Thu, 11 Mar 2021 03:11:41 -0800 Subject: [PATCH] Use old style isfinite Summary: Avoid using the newish member function isfinite. We use torch.isfinite instead for torch 1.4.0 compatibility. Reviewed By: nikhilaravi Differential Revision: D26946672 fbshipit-source-id: 853c3716f40061152f1ea54a39eb60b565de7c2c --- tests/test_points_to_volumes.py | 2 +- tests/test_raymarching.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test_points_to_volumes.py b/tests/test_points_to_volumes.py index 75b0a7c8..c72deeb9 100644 --- a/tests/test_points_to_volumes.py +++ b/tests/test_points_to_volumes.py @@ -354,7 +354,7 @@ class TestPointsToVolumes(TestCaseMixin, unittest.TestCase): # this does not produce grads w.r.t. xyz self.assertIsNone(field.grad) else: - self.assertTrue(field.grad.data.isfinite().all()) + self.assertTrue(torch.isfinite(field.grad.data).all()) def _check_volume_slice_color_density( self, V, split_dim, interp_mode, clr_gt, slice_type, border=3 diff --git a/tests/test_raymarching.py b/tests/test_raymarching.py index 9e3a64bc..9b77b01b 100644 --- a/tests/test_raymarching.py +++ b/tests/test_raymarching.py @@ -163,7 +163,7 @@ class TestRaymarching(TestCaseMixin, unittest.TestCase): loss = features_render.mean() loss.backward() for field in (rays_densities, rays_features): - self.assertTrue(field.grad.data.isfinite().all()) + self.assertTrue(torch.isfinite(field.grad.data).all()) def test_absorption_only(self): """ @@ -193,4 +193,4 @@ class TestRaymarching(TestCaseMixin, unittest.TestCase): # check differentiability loss = opacities_render.mean() loss.backward() - self.assertTrue(rays_densities.grad.data.isfinite().all()) + self.assertTrue(torch.isfinite(rays_densities.grad.data).all())