diff --git a/projects/implicitron_trainer/impl/optimizer_factory.py b/projects/implicitron_trainer/impl/optimizer_factory.py index a4f0c0f8..1ec31653 100644 --- a/projects/implicitron_trainer/impl/optimizer_factory.py +++ b/projects/implicitron_trainer/impl/optimizer_factory.py @@ -121,7 +121,6 @@ class ImplicitronOptimizerFactory(OptimizerFactoryBase): """ # Get the parameters to optimize if hasattr(model, "_get_param_groups"): # use the model function - # pyre-ignore[29] p_groups = model._get_param_groups(self.lr, wd=self.weight_decay) else: p_groups = [ diff --git a/projects/implicitron_trainer/impl/training_loop.py b/projects/implicitron_trainer/impl/training_loop.py index d31a493b..57917cc8 100644 --- a/projects/implicitron_trainer/impl/training_loop.py +++ b/projects/implicitron_trainer/impl/training_loop.py @@ -110,6 +110,8 @@ class ImplicitronTrainingLoop(TrainingLoopBase): def __post_init__(self): run_auto_creation(self) + # pyre-fixme[14]: `run` overrides method defined in `TrainingLoopBase` + # inconsistently. def run( self, *, @@ -391,7 +393,6 @@ class ImplicitronTrainingLoop(TrainingLoopBase): ): prefix = f"e{stats.epoch}_it{stats.it[trainmode]}" if hasattr(model, "visualize"): - # pyre-ignore [29] model.visualize( viz, visdom_env_imgs,