From f4f22092712251d9bf0f01519dbadb1419480ae0 Mon Sep 17 00:00:00 2001
From: Jeremy Reizenstein <reizenstein@meta.com>
Date: Tue, 14 Nov 2023 07:42:18 -0800
Subject: [PATCH] Fix for mask_points=False

Summary: Remove unused argument `mask_points` from `get_rgbd_point_cloud` and fix `get_implicitron_sequence_pointcloud`, which assumed it was used.

Reviewed By: MichaelRamamonjisoa

Differential Revision: D50885848

fbshipit-source-id: c0b834764ad5ef560107bd8eab04952d000489b8
---
 pytorch3d/implicitron/dataset/visualize.py       | 3 +--
 pytorch3d/implicitron/tools/point_cloud_utils.py | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/pytorch3d/implicitron/dataset/visualize.py b/pytorch3d/implicitron/dataset/visualize.py
index 8c277532..4ac633f6 100644
--- a/pytorch3d/implicitron/dataset/visualize.py
+++ b/pytorch3d/implicitron/dataset/visualize.py
@@ -89,9 +89,8 @@ def get_implicitron_sequence_pointcloud(
             frame_data.image_rgb,
             frame_data.depth_map,
             (cast(torch.Tensor, frame_data.fg_probability) > 0.5).float()
-            if frame_data.fg_probability is not None
+            if mask_points and frame_data.fg_probability is not None
             else None,
-            mask_points=mask_points,
         )
 
     return point_cloud, frame_data
diff --git a/pytorch3d/implicitron/tools/point_cloud_utils.py b/pytorch3d/implicitron/tools/point_cloud_utils.py
index af2abe64..904e4567 100644
--- a/pytorch3d/implicitron/tools/point_cloud_utils.py
+++ b/pytorch3d/implicitron/tools/point_cloud_utils.py
@@ -26,7 +26,7 @@ def get_rgbd_point_cloud(
     depth_map: torch.Tensor,
     mask: Optional[torch.Tensor] = None,
     mask_thr: float = 0.5,
-    mask_points: bool = True,
+    *,
     euclidean: bool = False,
 ) -> Pointclouds:
     """