423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-02 03:42:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Enable black + isort fbsource linter

Browse Source 
Summary:
Enable `black` + `isort` (via `pyfmt`) i.e. `BLACK` fbsource linter.

NOTE: the `BLACK` fbsource linter (and `black` itself) is (by design) ***not*** configurable. This forces aligning the existing options used by the tools invoked in `dev/linter.sh` (for 3rd party developers) with `BLACK` fbsource linting. Without this reconciliation, the different linters (used internally or by 3rd party developers) would simply conflict with each other resulting in artificial back-and-forth changes (for instance line width which `BLACK` forces to 88 characters).

Reviewed By: nikhilaravi

Differential Revision: D20558374

fbshipit-source-id: 614fa00664f8eb9d2de7438c29b807dfbf36ad20
This commit is contained in:
Patrick Labatut 2020-03-29 14:46:33 -07:00 committed by Facebook GitHub Bot
parent 37c5c8e0b6
commit eb512ffde3
3 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.flake8
View File

@ -1,6 +1,6 @@
[flake8] [flake8]
ignore = E203, E266, E501, W503, E221 ignore = E203, E266, E501, W503, E221
max-line-length = 80 max-line-length = 88
max-complexity = 18 max-complexity = 18
select = B,C,E,F,W,T4,B9 select = B,C,E,F,W,T4,B9
exclude = build,__init__.py exclude = build,__init__.py

2
dev/linter.sh
View File

@ -19,7 +19,7 @@ echo "Running isort..."
isort -y -sp "${DIR}" isort -y -sp "${DIR}"
echo "Running black..." echo "Running black..."
black -l 80 "${DIR}" black "${DIR}"
echo "Running flake..." echo "Running flake..."
flake8 "${DIR}" flake8 "${DIR}"

17
setup.cfg
View File

@ -1,13 +1,10 @@
# Copyright (c) Facebook, Inc. and its affiliates. All rights reserved. # Copyright (c) Facebook, Inc. and its affiliates. All rights reserved.
[isort] [isort]
line_length=80 line_length = 88
include_trailing_comma=True multi_line_output = 3
multi_line_output=3 include_trailing_comma = True
known_standard_library=numpy,setuptools force_grid_warp = 0
known_myself=pytorch3d default_section = THIRDPARTY
known_third_party=fvcore,torch,torchvision,matplotlib,mpl_toolkits,PIL,yaml lines_after_imports = 2
jinja2,requests,nbformat,nbconvert,bs4 combine_as_imports = True
no_lines_before=STDLIB,THIRDPARTY
sections=FUTURE,STDLIB,THIRDPARTY,myself,FIRSTPARTY,LOCALFOLDER
default_section=FIRSTPARTY