423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2026-01-17 03:40:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

test tolerance loosenings

Browse Source 
Summary: Increase some test tolerances so that they pass in more situations, and re-enable two tests.

Reviewed By: nikhilaravi

Differential Revision: D31379717

fbshipit-source-id: 06a25470cc7b6d71cd639d9fd7df500d4b84c079
This commit is contained in:
Jeremy Reizenstein
2021-10-07 10:46:46 -07:00
committed by Facebook GitHub Bot
parent 8fa438cbda
commit b26f4bc33a
3 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/test_points_alignment.py
View File

@@ -159,12 +159,13 @@ class TestICP(TestCaseMixin, unittest.TestCase):
self.assertClose(s_init, s, atol=atol)
self.assertClose(Xt_init, Xt, atol=atol)
def test_heterogeneous_inputs(self, batch_size=10):
def test_heterogeneous_inputs(self, batch_size=7):
"""
Tests whether we get the same result when running ICP on
a set of randomly-sized Pointclouds and on their padded versions.
"""
torch.manual_seed(4)
device = torch.device("cuda:0")
for estimate_scale in (True, False):
@@ -501,7 +502,6 @@ class TestCorrespondingPointsAlignment(TestCaseMixin, unittest.TestCase):
- use_pointclouds ... If True, passes the Pointclouds objects
to corresponding_points_alignment.
"""
self.skipTest("Temporarily disabled pending investigation")
# run this for several different point cloud sizes
for n_points in (100, 3, 2, 1):
# run this for several different dimensionalities
@@ -640,7 +640,10 @@ class TestCorrespondingPointsAlignment(TestCaseMixin, unittest.TestCase):
if reflect and not allow_reflection:
# check that all rotations have det=1
self._assert_all_close(
torch.det(R_est), R_est.new_ones(batch_size), assert_error_message
torch.det(R_est),
R_est.new_ones(batch_size),
assert_error_message,
atol=2e-5,
)
else:
@@ -665,13 +668,13 @@ class TestCorrespondingPointsAlignment(TestCaseMixin, unittest.TestCase):
desired_det = R_est.new_ones(batch_size)
if reflect:
desired_det *= -1.0
self._assert_all_close(torch.det(R_est), desired_det, msg, w)
self._assert_all_close(torch.det(R_est), desired_det, msg, w, atol=2e-5)
# check that the transformed point cloud
# X matches X_t
X_t_est = _apply_pcl_transformation(X, R_est, T_est, s=s_est)
self._assert_all_close(
X_t, X_t_est, assert_error_message, w[:, None, None], atol=1e-5
X_t, X_t_est, assert_error_message, w[:, None, None], atol=2e-5
)
def _assert_all_close(self, a_, b_, err_message, weights=None, atol=1e-6):