423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-02 03:42:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused-but-set variables in vision/fair/pytorch3d/pytorch3d/csrc/pulsar/include/renderer.render.device.h +1

Browse Source 
Summary:
This diff removes a variable that was set, but which was not used.

LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.

Removing this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. I've gone through each of these by hand, but mistakes may have slipped through. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.

For questions/comments, contact r-barnes.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: bottler

Differential Revision: D56886956

fbshipit-source-id: 0c515ed98b812b1c106a59e19ec90751ce32e8c0
This commit is contained in:
Richard Barnes 2024-05-02 13:58:05 -07:00 committed by Facebook GitHub Bot
parent 47d5dc8824
commit aec76bb4c8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pytorch3d/csrc/pulsar/include/renderer.render.device.h
View File

@ -99,7 +99,7 @@ GLOBAL void render(
/** Whether loading of balls is completed. */ /** Whether loading of balls is completed. */
SHARED bool loading_done; SHARED bool loading_done;
/** The number of balls loaded overall (just for statistics). */ /** The number of balls loaded overall (just for statistics). */
SHARED int n_balls_loaded; [[maybe_unused]] SHARED int n_balls_loaded;
/** The area this thread block covers. */ /** The area this thread block covers. */
SHARED IntersectInfo block_area; SHARED IntersectInfo block_area;
if (thread_block.thread_rank() == 0) { if (thread_block.thread_rank() == 0) {