423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-11-04 18:02:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add safeguard in case num_tris diverges

Browse Source 
Summary:
This PR fixes adds a safeguard preventing num_tris to overflow in `MAX_TRIS`-length arrays. The update rule of `num_tris` is bounded :

 - max(num_tris(t)) = 2*num_tris(t-1)
 - num_tris(0) = 12
 - t <= 6

So :
 - max(num_tris) = 2^6*12
 - max(num_tris) = 768

Reviewed By: bottler

Differential Revision: D66162573

fbshipit-source-id: e269a79c75c6cc33306986b1f1256cffbe96c730
This commit is contained in:
Yann Noutary 2024-11-20 01:24:28 -08:00 committed by Facebook GitHub Bot
parent 81d82980bc
commit 91c9f34137
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pytorch3d/csrc/iou_box3d/iou_utils.cuh
View File

@ -728,7 +728,7 @@ __device__ inline int BoxIntersections(
} }
} }
// Update the face_verts_out tris // Update the face_verts_out tris
num_tris = offset; num_tris = min(MAX_TRIS, offset);
for (int j = 0; j < num_tris; ++j) { for (int j = 0; j < num_tris; ++j) {
face_verts_out[j] = tri_verts_updated[j]; face_verts_out[j] = tri_verts_updated[j];
} }