423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-03 04:12:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add **kwargs to ViewMetrics.forward

Browse Source 
Summary: GenericModel crashes in case the `aux` field of any Renderer is populated. This is because the `rendered.aux` is unpacked to  ViewMetrics.forward whose signature does not contain **kwargs. Hence, the contents of `aux` are unknown to forward's signature resulting in a crash.

Reviewed By: bottler

Differential Revision: D36166118

fbshipit-source-id: 906a067ea02a3648a69667422466451bc219ebf6
This commit is contained in:
David Novotny 2022-05-09 03:04:34 -07:00 committed by Facebook GitHub Bot
parent 2c64635daa
commit 5c59841863
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pytorch3d/implicitron/models/metrics.py
View File

@ -28,6 +28,7 @@ class ViewMetrics(torch.nn.Module):
density_grid: Optional[torch.Tensor] = None, density_grid: Optional[torch.Tensor] = None,
keys_prefix: str = "loss_", keys_prefix: str = "loss_",
mask_renders_by_pred: bool = False, mask_renders_by_pred: bool = False,
**kwargs,
) -> Dict[str, torch.Tensor]: ) -> Dict[str, torch.Tensor]:
""" """
Calculates various differentiable metrics useful for supervising Calculates various differentiable metrics useful for supervising