From 5218f45c2c3b254d7a82515b24cbac6902296b8f Mon Sep 17 00:00:00 2001 From: Patrick Labatut Date: Wed, 18 Mar 2020 11:36:12 -0700 Subject: [PATCH] Add pattern linter for project names Summary: Add pattern linter for PyTorch3D and SlowFast, this will suggest typo fixes whenever the wrong case is accidentally used. Reviewed By: wanyenlo Differential Revision: D20498696 fbshipit-source-id: 1a3f4702bd0dbe06e81d0f301b3ea38ea62e7885 --- INSTALL.md | 2 +- README.md | 2 +- pytorch3d/renderer/cameras.py | 2 +- scripts/parse_tutorials.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/INSTALL.md b/INSTALL.md index 389dbed4..232c71b4 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -45,7 +45,7 @@ pip install scikit-image matplotlib imageio pip install black isort flake8 flake8-bugbear flake8-comprehensions ``` -## Installing prebuilt binaries for Pytorch3d +## Installing prebuilt binaries for PyTorch3D After installing the above dependencies, run one of the following commands: ### 1. Install with CUDA support from Anaconda Cloud, on Linux only diff --git a/README.md b/README.md index ed4a10ad..11a3282a 100644 --- a/README.md +++ b/README.md @@ -55,7 +55,7 @@ We also have deep dive notes on several API components: ## Development -We welcome new contributions to Pytorch3d and we will be actively maintaining this library! Please refer to [CONTRIBUTING.md](./.github/CONTRIBUTING.md) for full instructions on how to run the code, tests and linter, and submit your pull requests. +We welcome new contributions to PyTorch3D and we will be actively maintaining this library! Please refer to [CONTRIBUTING.md](./.github/CONTRIBUTING.md) for full instructions on how to run the code, tests and linter, and submit your pull requests. ## Contributors diff --git a/pytorch3d/renderer/cameras.py b/pytorch3d/renderer/cameras.py index 792724f0..94ae48d3 100644 --- a/pytorch3d/renderer/cameras.py +++ b/pytorch3d/renderer/cameras.py @@ -879,7 +879,7 @@ def get_world_to_view_transform(R=r, T=t) -> Transform3d: matrix to go from world space to view space by applying a rotation and a translation. - Pytorch3d uses the same convention as Hartley & Zisserman. + PyTorch3D uses the same convention as Hartley & Zisserman. I.e., for camera extrinsic parameters R (rotation) and T (translation), we map a 3D point `X_world` in world coordinates to a point `X_cam` in camera coordinates with: diff --git a/scripts/parse_tutorials.py b/scripts/parse_tutorials.py index 155aebeb..638ba890 100755 --- a/scripts/parse_tutorials.py +++ b/scripts/parse_tutorials.py @@ -110,7 +110,7 @@ if __name__ == "__main__": "--repo_dir", metavar="path", required=True, - help="Pytorch3D repo directory.", + help="PyTorch3D repo directory.", ) args = parser.parse_args() gen_tutorials(args.repo_dir)