From 5053142363afca730c44ed2bd1a6aa24d4fc7635 Mon Sep 17 00:00:00 2001 From: Jeremy Reizenstein Date: Mon, 24 Jan 2022 10:51:03 -0800 Subject: [PATCH] typing for unproject_points Summary: Fix the base class annotation for unproject_points. Reviewed By: patricklabatut Differential Revision: D33281586 fbshipit-source-id: 1c34e8c4b30b359fcb9307507bc778ad3fecf290 --- pytorch3d/renderer/cameras.py | 2 +- pytorch3d/renderer/implicit/raysampling.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pytorch3d/renderer/cameras.py b/pytorch3d/renderer/cameras.py index 1225381e..a840d54b 100644 --- a/pytorch3d/renderer/cameras.py +++ b/pytorch3d/renderer/cameras.py @@ -98,7 +98,7 @@ class CamerasBase(TensorProperties): """ raise NotImplementedError() - def unproject_points(self): + def unproject_points(self, xy_depth: torch.Tensor, **kwargs): """ Transform input points from camera coodinates (NDC or screen) to the world / camera coordinates. diff --git a/pytorch3d/renderer/implicit/raysampling.py b/pytorch3d/renderer/implicit/raysampling.py index c4e4139d..e868a18d 100644 --- a/pytorch3d/renderer/implicit/raysampling.py +++ b/pytorch3d/renderer/implicit/raysampling.py @@ -549,7 +549,7 @@ def _xy_to_ray_bundle( ) # unproject the points - unprojected = cameras.unproject_points(to_unproject, from_ndc=True) # pyre-ignore + unprojected = cameras.unproject_points(to_unproject, from_ndc=True) # split the two planes back rays_plane_1_world = unprojected[:, :n_rays_per_image]