From 4f8a2f197905dd419ec4dc15fc18fbb578d98a37 Mon Sep 17 00:00:00 2001 From: Eduardo Henrique Arnold Date: Tue, 29 Sep 2020 09:45:48 -0700 Subject: [PATCH] Fixing look_at_view_transform documentation, azim angle definition was incorrect (#251) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: …between the projection on the y=0 plane and reference vector (0,0,1). Fixes https://github.com/facebookresearch/pytorch3d/issues/229 Pull Request resolved: https://github.com/facebookresearch/pytorch3d/pull/251 Reviewed By: gkioxari Differential Revision: D23967073 Pulled By: nikhilaravi fbshipit-source-id: fb6f10d4b7f5e319d17e28b4316837205b637f5e --- pytorch3d/renderer/cameras.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pytorch3d/renderer/cameras.py b/pytorch3d/renderer/cameras.py index e14c8be8..117a98fe 100644 --- a/pytorch3d/renderer/cameras.py +++ b/pytorch3d/renderer/cameras.py @@ -1260,7 +1260,7 @@ def look_at_view_transform( azim: angle in degrees or radians. The vector from the object to the camera is projected onto a horizontal plane y = 0. azim is the angle between the projected vector and a - reference vector at (1, 0, 0) on the reference plane (the horizontal plane). + reference vector at (0, 0, 1) on the reference plane (the horizontal plane). dist, elem and azim can be of shape (1), (N). degrees: boolean flag to indicate if the elevation and azimuth angles are specified in degrees or radians.