423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-02 20:02:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change default settings of clip_barycentric_coords

Browse Source 
Summary: When raster_settings.clip_barycentric_coords is unspecified, clip_barycentric_coords is turned on if blur_radius is greater than 0.  This matches the behavior prior to D21705503 (cc70950f40).

Reviewed By: gkioxari

Differential Revision: D23375257

fbshipit-source-id: 4b87588aabb69d4d835d4dcceb11153628121d30
This commit is contained in:
Steve Branson 2020-08-27 16:42:40 -07:00 committed by Facebook GitHub Bot
parent c25fd83694
commit 46c0e83461
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pytorch3d/renderer/mesh/rasterizer.py
View File

@ -37,7 +37,7 @@ class RasterizationSettings:
bin_size: Optional[int] = None, bin_size: Optional[int] = None,
max_faces_per_bin: Optional[int] = None, max_faces_per_bin: Optional[int] = None,
perspective_correct: bool = False, perspective_correct: bool = False,
clip_barycentric_coords: bool = False, clip_barycentric_coords: Optional[bool] = None,
cull_backfaces: bool = False, cull_backfaces: bool = False,
): ):
self.image_size = image_size self.image_size = image_size
@ -125,6 +125,14 @@ class MeshRasterizer(nn.Module):
""" """
meshes_screen = self.transform(meshes_world, **kwargs) meshes_screen = self.transform(meshes_world, **kwargs)
raster_settings = kwargs.get("raster_settings", self.raster_settings) raster_settings = kwargs.get("raster_settings", self.raster_settings)
# By default, turn on clip_barycentric_coords if blur_radius > 0.
# When blur_radius > 0, a face can be matched to a pixel that is outside the
# face, resulting in negative barycentric coordinates.
clip_barycentric_coords = raster_settings.clip_barycentric_coords
if clip_barycentric_coords is None:
clip_barycentric_coords = raster_settings.blur_radius > 0.0
# TODO(jcjohns): Should we try to set perspective_correct automatically # TODO(jcjohns): Should we try to set perspective_correct automatically
# based on the type of the camera? # based on the type of the camera?
pix_to_face, zbuf, bary_coords, dists = rasterize_meshes( pix_to_face, zbuf, bary_coords, dists = rasterize_meshes(
@ -135,7 +143,7 @@ class MeshRasterizer(nn.Module):
bin_size=raster_settings.bin_size, bin_size=raster_settings.bin_size,
max_faces_per_bin=raster_settings.max_faces_per_bin, max_faces_per_bin=raster_settings.max_faces_per_bin,
perspective_correct=raster_settings.perspective_correct, perspective_correct=raster_settings.perspective_correct,
clip_barycentric_coords=raster_settings.clip_barycentric_coords, clip_barycentric_coords=clip_barycentric_coords,
cull_backfaces=raster_settings.cull_backfaces, cull_backfaces=raster_settings.cull_backfaces,
) )
return Fragments( return Fragments(