Fix: making visualisation work again

Summary:
1. Respecting `visdom_show_preds` parameter when it is False.
2. Clipping the images pre-visualisation, which is important for methods like SRN that are not arare of pixel value range.

Reviewed By: bottler

Differential Revision: D37786439

fbshipit-source-id: 8dbb5104290bcc5c2829716b663cae17edc911bd
This commit is contained in:
Roman Shapovalov 2022-07-13 05:29:09 -07:00 committed by Facebook GitHub Bot
parent af55ba01f8
commit 4261e59f51
2 changed files with 10 additions and 9 deletions

View File

@ -638,7 +638,7 @@ def _seed_all_random_engines(seed: int) -> None:
random.seed(seed) random.seed(seed)
def _setup_envvars_for_cluster(cfg) -> bool: def _setup_envvars_for_cluster() -> bool:
""" """
Prepares to run on cluster if relevant. Prepares to run on cluster if relevant.
Returns whether FAIR cluster in use. Returns whether FAIR cluster in use.

View File

@ -251,7 +251,7 @@ def show_predictions(
def generate_prediction_videos( def generate_prediction_videos(
preds, preds,
sequence_name, sequence_name,
viz, viz=None,
viz_env="visualizer", viz_env="visualizer",
predicted_keys=( predicted_keys=(
"images_render", "images_render",
@ -279,13 +279,14 @@ def generate_prediction_videos(
for rendered_pred in tqdm(preds): for rendered_pred in tqdm(preds):
for k in predicted_keys: for k in predicted_keys:
vws[k].write_frame( vws[k].write_frame(
rendered_pred[k][0].detach().cpu().numpy(), rendered_pred[k][0].clip(0.0, 1.0).detach().cpu().numpy(),
resize=resize, resize=resize,
) )
for k in predicted_keys: for k in predicted_keys:
vws[k].get_video(quiet=True) vws[k].get_video(quiet=True)
print(f"Generated {vws[k].out_path}.") print(f"Generated {vws[k].out_path}.")
if viz is not None:
viz.video( viz.video(
videofile=vws[k].out_path, videofile=vws[k].out_path,
env=viz_env, env=viz_env,