423A35C7/pytorch3d
1
0
Fork 0
mirror of https://github.com/facebookresearch/pytorch3d.git synced 2025-08-02 11:52:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix Optional[List] in Configurable

Browse Source 
Summary: Optional[not_a_type] was causing errors.

Reviewed By: davnov134

Differential Revision: D35355530

fbshipit-source-id: e9b52cfd6347ffae0fe688ef30523a4092ccf9fd
This commit is contained in:
Jeremy Reizenstein 2022-04-04 04:28:17 -07:00 committed by Facebook GitHub Bot
parent a999fc22ee
commit 2802fd9398
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pytorch3d/implicitron/tools/config.py
View File

@ -746,7 +746,8 @@ def _get_type_to_process(type_) -> Optional[Tuple[Type, _ProcessType]]:
return return
underlying = args[0] if args[1] is type(None) else args[1] # noqa: E721 underlying = args[0] if args[1] is type(None) else args[1] # noqa: E721
if ( if (
issubclass(underlying, ReplaceableBase) isinstance(underlying, type)
and issubclass(underlying, ReplaceableBase)
and ReplaceableBase in underlying.__bases__ and ReplaceableBase in underlying.__bases__
): ):
return underlying, _ProcessType.OPTIONAL_REPLACEABLE return underlying, _ProcessType.OPTIONAL_REPLACEABLE

1
tests/implicitron/test_config.py
View File

@ -109,6 +109,7 @@ class TestConfig(unittest.TestCase):
self.assertIsNone(gt(Optional[MainTest])) self.assertIsNone(gt(Optional[MainTest]))
self.assertIsNone(gt(Tuple[Fruit])) self.assertIsNone(gt(Tuple[Fruit]))
self.assertIsNone(gt(Tuple[Fruit, Animal])) self.assertIsNone(gt(Tuple[Fruit, Animal]))
self.assertIsNone(gt(Optional[List[int]]))
def test_simple_replacement(self): def test_simple_replacement(self):
struct = get_default_args(MainTest) struct = get_default_args(MainTest)