From c083708433328915f92189c6cee36c44e0454f7f Mon Sep 17 00:00:00 2001 From: marko1616 Date: Sun, 24 Mar 2024 02:44:35 +0800 Subject: [PATCH 1/4] fix Llama lora merge crash Former-commit-id: c1e2c4ea45ad210e776a192e05e226b34d764135 --- src/llmtuner/train/tuner.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/llmtuner/train/tuner.py b/src/llmtuner/train/tuner.py index 1b8e3cb7..e9b195de 100644 --- a/src/llmtuner/train/tuner.py +++ b/src/llmtuner/train/tuner.py @@ -64,6 +64,15 @@ def export_model(args: Optional[Dict[str, Any]] = None): for param in model.parameters(): param.data = param.data.to(output_dtype) + # Configuration check and fix + config = model.generation_config + if config.do_sample and ( + (config.temperature is not None and config.temperature != 1.0) or + (config.top_p is not None and config.top_p != 1.0) or + (config.typical_p is not None and config.typical_p != 1.0) + ): + config.do_sample = False + model.save_pretrained( save_directory=model_args.export_dir, max_shard_size="{}GB".format(model_args.export_size), From 645c27e5e2ab4e8b6b94394533c97979fd6af9b9 Mon Sep 17 00:00:00 2001 From: marko1616 Date: Sun, 24 Mar 2024 02:55:23 +0800 Subject: [PATCH 2/4] fix Llama lora merge crash Former-commit-id: 51349ea1ccbf3e53b408037986abd850a0963468 --- src/llmtuner/train/tuner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/llmtuner/train/tuner.py b/src/llmtuner/train/tuner.py index e9b195de..cd532f5e 100644 --- a/src/llmtuner/train/tuner.py +++ b/src/llmtuner/train/tuner.py @@ -71,7 +71,7 @@ def export_model(args: Optional[Dict[str, Any]] = None): (config.top_p is not None and config.top_p != 1.0) or (config.typical_p is not None and config.typical_p != 1.0) ): - config.do_sample = False + config.do_sample = True model.save_pretrained( save_directory=model_args.export_dir, From a68101cbbb013bfb2cfb6e49766600907b97c219 Mon Sep 17 00:00:00 2001 From: marko1616 Date: Sun, 24 Mar 2024 03:06:11 +0800 Subject: [PATCH 3/4] fix Llama lora merge crash Former-commit-id: 6f080fdba3f99145b7722964dd027179dc2eeb2b --- src/llmtuner/train/tuner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/llmtuner/train/tuner.py b/src/llmtuner/train/tuner.py index cd532f5e..8eda9676 100644 --- a/src/llmtuner/train/tuner.py +++ b/src/llmtuner/train/tuner.py @@ -66,7 +66,7 @@ def export_model(args: Optional[Dict[str, Any]] = None): # Configuration check and fix config = model.generation_config - if config.do_sample and ( + if config.do_sample == False and ( (config.temperature is not None and config.temperature != 1.0) or (config.top_p is not None and config.top_p != 1.0) or (config.typical_p is not None and config.typical_p != 1.0) From 1d0e24549f5266aeeedbf00c6a27ce3d7de61260 Mon Sep 17 00:00:00 2001 From: marko1616 Date: Sun, 24 Mar 2024 16:12:10 +0800 Subject: [PATCH 4/4] pass ruff check Former-commit-id: c8f0d99704308ac1886b16e437dea601eb20658d --- src/llmtuner/train/tuner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/llmtuner/train/tuner.py b/src/llmtuner/train/tuner.py index 8eda9676..9074572a 100644 --- a/src/llmtuner/train/tuner.py +++ b/src/llmtuner/train/tuner.py @@ -66,7 +66,7 @@ def export_model(args: Optional[Dict[str, Any]] = None): # Configuration check and fix config = model.generation_config - if config.do_sample == False and ( + if not config.do_sample and ( (config.temperature is not None and config.temperature != 1.0) or (config.top_p is not None and config.top_p != 1.0) or (config.typical_p is not None and config.typical_p != 1.0)