423A35C7/LLaMA-Factory
1
0
Fork 0
mirror of https://github.com/hiyouga/LLaMA-Factory.git synced 2025-10-15 16:18:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6125 from hiyouga/hiyouga/fix_cli

Browse Source 
[cli] remove shell=True in cli

Former-commit-id: cf3ec28baa9a9f1ba342fe3a627e85d8799a1912
This commit is contained in:
hoshi-hiyouga 2024-11-25 00:07:35 +08:00 committed by GitHub
commit 3ec3dda33a
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/llamafactory/cli.py
View File

@ -95,7 +95,8 @@ def main():
( (
"torchrun --nnodes {nnodes} --node_rank {node_rank} --nproc_per_node {nproc_per_node} " "torchrun --nnodes {nnodes} --node_rank {node_rank} --nproc_per_node {nproc_per_node} "
"--master_addr {master_addr} --master_port {master_port} {file_name} {args}" "--master_addr {master_addr} --master_port {master_port} {file_name} {args}"
).format( )
.format(
nnodes=os.getenv("NNODES", "1"), nnodes=os.getenv("NNODES", "1"),
node_rank=os.getenv("NODE_RANK", "0"), node_rank=os.getenv("NODE_RANK", "0"),
nproc_per_node=os.getenv("NPROC_PER_NODE", str(get_device_count())), nproc_per_node=os.getenv("NPROC_PER_NODE", str(get_device_count())),
@ -103,8 +104,8 @@ def main():
master_port=master_port, master_port=master_port,
file_name=launcher.__file__, file_name=launcher.__file__,
args=" ".join(sys.argv[1:]), args=" ".join(sys.argv[1:]),
), )
shell=True, .split()
) )
sys.exit(process.returncode) sys.exit(process.returncode)
else: else: